Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Annotations: core.plugin #707

Closed
derks opened this issue Jun 22, 2024 · 0 comments
Closed

Type Annotations: core.plugin #707

derks opened this issue Jun 22, 2024 · 0 comments
Assignees
Milestone

Comments

@derks
Copy link
Member

derks commented Jun 22, 2024

Add initial type annotations.

Related:

Current Errors:

|> cement-py312 <| src # make comply-typing | grep core/plugin
cement/core/plugin.py:8: error: Call to untyped function "minimal_logger" in typed context  [no-untyped-call]
cement/core/plugin.py:26: error: Function is missing a type annotation  [no-untyped-def]
cement/core/plugin.py:37: error: Function is missing a type annotation  [no-untyped-def]
cement/core/plugin.py:48: error: Function is missing a return type annotation  [no-untyped-def]
cement/core/plugin.py:48: note: Use "-> None" if function does not return a value
cement/core/plugin.py:53: error: Function is missing a return type annotation  [no-untyped-def]
cement/core/plugin.py:53: note: Use "-> None" if function does not return a value
cement/core/plugin.py:58: error: Function is missing a return type annotation  [no-untyped-def]
cement/core/plugin.py:58: note: Use "-> None" if function does not return a value
cement/core/plugin.py:63: error: Definition of "Meta" in base class "PluginInterface" is incompatible with definition in base class "Handler"  [misc]
cement/core/plugin.py:63: error: Definition of "Meta" in base class "Interface" is incompatible with definition in base class "Handler"  [misc]
make: *** [Makefile:33: comply-typing] Error 1
@derks derks added this to the 3.0.12 Stable milestone Jun 22, 2024
@derks derks self-assigned this Jul 13, 2024
derks added a commit that referenced this issue Jul 13, 2024
    - Resolves Issue #707
    - Related to PR #628
@derks derks closed this as completed Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant