Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous double quotes getting wrapped around parameters that have non-word characters #19

Closed
evanstachowiak opened this issue Mar 3, 2014 · 4 comments
Assignees
Milestone

Comments

@evanstachowiak
Copy link

I believe this is the culprit:
https://github.com/datafolklabs/ruby-parseconfig/blob/master/lib/parseconfig.rb#L161

Is there a reason that parameters are getting wrapped with double-quotes in this case? I'm using this to work with aws config files and it is an issue for me.

derks added a commit that referenced this issue Mar 3, 2014
@derks
Copy link
Member

derks commented Mar 3, 2014

@evanstachowiak can you checkout, and try the master branch? pushed up a change.. the default is to quote config values by default, however you can now disable quoting:

require 'parseconfig'
c = ParseConfig.new('/path/to/my/config')
c.write(STDOUT, quoted=false)

Hope that helps. Also, it has been years since I've coded with Ruby (everything I do is Python now), so if you have any interested in helping maintain this library please let me know. It could really use some love.

@evanstachowiak
Copy link
Author

@derks thanks for the quick response!

Works now, however, I had to massage the gemspec a bit. Is there a reason it's in the utils/ folder instead of the top-level? This is causing:

s.files = ["README.md", "Changelog", "LICENSE", "doc", "lib/parseconfig.rb", "tests"]

to bork.

If you move gemspec into the top-level it works fine.

I may be interested in helping. send a PM to evan dot stachowiak at gmail dot com

@derks
Copy link
Member

derks commented Mar 4, 2014

No reason, but I've never had an issue with it:

$ gem build utils/parseconfig.gemspec
  Successfully built RubyGem
  Name: parseconfig
  Version: 1.0.5
  File: parseconfig-1.0.5.gem

@evanstachowiak
Copy link
Author

Interesting, maybe because I did
cd utils; gem build parseconfig.gemspec
and it couldn't find the lib path.

Anyways, thanks again for the update.

@derks derks closed this as completed Oct 6, 2014
@derks derks added this to the 1.0.6 Stable milestone Oct 6, 2014
@derks derks self-assigned this Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants