Sandbox2 wrapper #1536
Merged
Sandbox2 wrapper #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould try using bazel pathed nodejs version
…er. Still have fd > -1 error though
* Bump protobufjs from 6.8.8 to 6.11.3 Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 6.8.8 to 6.11.3. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/v6.11.3/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@6.8.8...v6.11.3) --- updated-dependencies: - dependency-name: protobufjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update protobufjs dep versions * Upgrade to protobufjs v7.0.0, node to 16x * Bump bazel to version 5.2.0 * Bump test CI to correct bazel version * 3.5.0 * 3.5.0 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lewis Hemens <lewishemens@google.com>
Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.0.0 to 7.2.4. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@protobufjs-v7.0.0...protobufjs-v7.2.4) --- updated-dependencies: - dependency-name: protobufjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Include multiline string literals when creating statements * Bump version to 2.6.2
This reverts commit 7c970c3.
This reverts commit 6fdb5f6.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Ekrekr
reviewed
Aug 30, 2023
| { | ||
| auto result = s2.AwaitResultWithTimeout( | ||
| absl::Seconds(TIMEOUT_SECS + FALLBACK_TIMEOUT_DELAY)); | ||
| LOG(ERROR) << "sandbox failed to start: " << result->ToString(); |
There was a problem hiding this comment.
Are things logged to stderr readable from the Javascript? I'm slightly confused by the socket usage above.
There was a problem hiding this comment.
They are, but we don't read them. But this might be useful if we do run into errors, that they will be in our logs at least.
Basically, all we care about is the process return code for the sandbox. The logs are ignored, and all communication back to the parent parent process goes indirectly via the socket - the path to which we pass along as an argument.
There was a problem hiding this comment.
Fair enough, if we need to add errors based off of the sandbox2 final result code we can do that later
Ekrekr
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Sandbox2 wrapper for compilation.
Disable tests for CLI (which is now broken in this branch), and integration tests that have a package dependency issue on this older branch.