Remove dynamic warehouse inference, and more clearly differentiate core and api's SQL adapters #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewish
approved these changes
Oct 18, 2023
| incremental?: boolean; | ||
| } | ||
|
|
||
| export class ExecutionSqlAdapter { |
There was a problem hiding this comment.
nit: these aren't really Adapters anymore, it's just a ... helper?
There was a problem hiding this comment.
Have removed that suffix altogether!
Ekrekr
added a commit
that referenced
this pull request
Oct 27, 2023
…re and api's SQL adapters (#1554) * More clearly differentiate core and api's SQL adapters * Remove helper namespace * Fix some opinionated imports and class usage * Fix more import orders
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
…re and api's SQL adapters (dataform-co#1554) * More clearly differentiate core and api's SQL adapters * Remove helper namespace * Fix some opinionated imports and class usage * Fix more import orders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes core easier to update