Add initial action config proto definitions #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBirt
approved these changes
Nov 14, 2023
Comment on lines
+366
to
+367
| // TODO(ekrekr): remove this empty message, if explicit action type without a | ||
| // `type` field proves to be impossible / ugly. |
There was a problem hiding this comment.
fwiw: i am much more comfortable keeping this message around now that we no longer have a type field - it has semantic purpose now.
There was a problem hiding this comment.
Nice - I want to make sure that all use cases do end up being OK without type while I play around with this a bit, which is why I've left this comment.
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.