Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test coverage of variables and project config overrides for Dataform Core #1603

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Add more test coverage of variables and project config overrides for Dataform Core #1603

merged 5 commits into from
Dec 6, 2023

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Dec 4, 2023 •
edited
Loading

@Ekrekr Ekrekr requested a review from BenBirt December 4, 2023 17:42
@Ekrekr Ekrekr mentioned this pull request Dec 4, 2023
Open
@Ekrekr Ekrekr merged commit b2cd68f into main_v3 Dec 6, 2023
4 checks passed
@Ekrekr Ekrekr deleted the contextable-config-test branch December 6, 2023 09:23
moker-spaghetti pushed a commit to moker-spaghetti/dataform that referenced this pull request May 26, 2024
@Ekrekr
Add more test coverage of variables and project config overrides for …
6b6c36c 
…Dataform Core (dataform-co#1603)

* Contextable config test

* Add a test for variable merging, and applying in SQLX config

* Add override for default schema

* Tidy

* Update core tests to use the var from the project config request for auto assertion database
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenBirt BenBirt BenBirt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ekrekr @BenBirt