Make filenames defined in action config files be treated as relative to the action config file #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolina
approved these changes
Jan 4, 2024
| // Users define file paths relative to action config path, but internally and in the | ||
| // compiled graph they are absolute paths. | ||
| actionConfig.fileName = | ||
| actionConfigsPath.substring(0, actionConfigsPath.length - "actions.yaml".length) + |
There was a problem hiding this comment.
NIT: put actions.yaml in some constant.
There was a problem hiding this comment.
Fair shout, I'll do this in a later follow up PR with all hardcoded filenames
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
…to the action config file (dataform-co#1636) * Update file name to be read as absolute * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.