Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose defaultLocation in dataform.projectConfig. #1705

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

BenBirt
Copy link
Collaborator

@BenBirt BenBirt commented Apr 2, 2024

No description provided.

@BenBirt BenBirt requested a review from Ekrekr April 2, 2024 10:07
@Ekrekr
Copy link
Contributor

Ekrekr commented Apr 2, 2024

Will this definitely fix the use case (I'm not sure what bug this is for). default location is already outputted in the compiled graph

defaultLocation: "US"

@BenBirt BenBirt merged commit a1dc4bd into main Apr 2, 2024
4 checks passed
@BenBirt BenBirt deleted the expose_default_location branch April 2, 2024 10:23
@BenBirt
Copy link
Collaborator Author

BenBirt commented Apr 2, 2024

Will this definitely fix the use case (I'm not sure what bug this is for). default location is already outputted in the compiled graph

defaultLocation: "US"

Yes, it should fix https://issuetracker.google.com/issues/331919803.

moker-spaghetti pushed a commit to moker-spaghetti/dataform that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants