Make example tests run off of the CLI, tidy testing/ #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Tuseeq1
approved these changes
May 9, 2024
| import { version } from "df/core/version"; | ||
| import { dataform } from "df/protos/ts"; | ||
| import { suite, test } from "df/testing"; | ||
| import { suite, test, getProcessResult, nodePath, npmPath, corePackageTarPath } from "df/testing"; |
There was a problem hiding this comment.
import should be alphabetized. same in other locations.
There was a problem hiding this comment.
Let's not bother if the linter won't do it, and it doesn't look there's a drop-in setting
There was a problem hiding this comment.
The linter was throwing, I somehow merged it before the tests finished lol - will update in subsequent PR
moker-spaghetti
pushed a commit
to moker-spaghetti/dataform
that referenced
this pull request
May 26, 2024
* Make example tests run off of the CLI, tidy testing/ * Tidy * Make example projects have separate datasets * Force trigger re-run * Force trigger re-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes dependence on the API part of the CLI, which should be private
Also tidy up project datasets, and
tests/utilswhich was weirdly located.