-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vscode extension crashes on windows #1751
Fix vscode extension crashes on windows #1751
Conversation
I think we don't actually have any tests for the VSCode extension, looking at the Can you share me your gmail address, and I will allowlist you to run the tests and CI pipeline anyway? You will be able to merge after that. I've assigned @GJMcGowan for review, as he is able to publish changes. |
@Ekrekr My gmail address is moker0spaghetti@gmail.com, thank you! |
@Ekrekr Thank you for the invitation to the group. I signed into the above account with
Also, I could not see any project listed in my Google Cloud Console. |
Hi Moker, I've granted some permissions for people in the
Let me know if this works! Thanks. |
Sorry, you won't be able to run these commands yet - there are some privacy and compliance exceptions I need to investigate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the fix!
@moker-spaghetti - thanks for the fix, this is now published on the extension store. |
I'm not sure how to run linter (I tried to run
scripts/lint
, but it ended up with an errorcould not require "tslint-config-prettier".
), so I'd appreciate any advice you can offer.Also, since this is my first PR to this project, please let me know if you notice any issues.