Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vscode extension crashes on windows #1751

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

moker-spaghetti
Copy link
Contributor

  1. Fix command name on windows to "dataform.cmd".
  2. Add error handling to prevent whole extension crash.

I'm not sure how to run linter (I tried to run scripts/lint, but it ended up with an error could not require "tslint-config-prettier".), so I'd appreciate any advice you can offer.
Also, since this is my first PR to this project, please let me know if you notice any issues.

@Ekrekr
Copy link
Contributor

Ekrekr commented May 30, 2024

  1. Fix command name on windows to "dataform.cmd".
  2. Add error handling to prevent whole extension crash.

I'm not sure how to run linter (I tried to run scripts/lint, but it ended up with an error could not require "tslint-config-prettier".), so I'd appreciate any advice you can offer. Also, since this is my first PR to this project, please let me know if you notice any issues.

I think we don't actually have any tests for the VSCode extension, looking at the vscode/BUILD file!

Can you share me your gmail address, and I will allowlist you to run the tests and CI pipeline anyway? You will be able to merge after that.

I've assigned @GJMcGowan for review, as he is able to publish changes.

@Ekrekr Ekrekr requested a review from GJMcGowan May 30, 2024 09:16
@moker-spaghetti
Copy link
Contributor Author

@Ekrekr My gmail address is moker0spaghetti@gmail.com, thank you!

@moker-spaghetti
Copy link
Contributor Author

@Ekrekr Thank you for the invitation to the group. I signed into the above account with gcloud auth login and run scripts/run_tests, but it ended up in the error below.

ERROR: /workspaces/dataform/test_credentials/BUILD:5:14: Action test_credentials/bigquery.json failed: (Exit 1): gcloud failed: error executing command external/gcloud_sdk/bin/gcloud kms decrypt '--ciphertext-file=test_credentials/bigquery.json.enc' '--plaintext-file=bazel-out/k8-py2-fastbuild/bin/test_credentials/bigquery.json' ... (remaining 4 arguments skipped)
ERROR: (gcloud.kms.decrypt) PERMISSION_DENIED: Permission 'cloudkms.cryptoKeyVersions.useToDecrypt' denied on resource 'projects/dataform-open-source/locations/global/keyRings/dataform-builder-keyring/cryptoKeys/dataform-builder-key' (or it may not exist).

Also, I could not see any project listed in my Google Cloud Console.
Do you have any advice?

@Ekrekr
Copy link
Contributor

Ekrekr commented Jun 3, 2024

Hi Moker,

I've granted some permissions for people in the dataform-open-source-contributors Google group. If everything works, you should now be able to:

  • Run ./scripts/run_tests.
  • Re-run the pull-request-trigger failed CI.

Let me know if this works!

Thanks.

@Ekrekr
Copy link
Contributor

Ekrekr commented Jun 4, 2024

Sorry, you won't be able to run these commands yet - there are some privacy and compliance exceptions I need to investigate.

Copy link
Collaborator

@GJMcGowan GJMcGowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix!

@Ekrekr Ekrekr merged commit 4e13354 into dataform-co:main Jun 24, 2024
1 of 2 checks passed
@GJMcGowan
Copy link
Collaborator

@moker-spaghetti - thanks for the fix, this is now published on the extension store.

@moker-spaghetti moker-spaghetti deleted the fix-vscode-crash-windows branch July 4, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants