Operation config as protos #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekrekr
changed the title
Ekrekr
requested review from
a team,
GJMcGowan and
Tuseeq1
and removed request for
a team and
GJMcGowan
Tuseeq1
approved these changes
Jul 1, 2024
Tuseeq1
reviewed
Jul 1, 2024
| @@ -75,8 +75,6 @@ export class Assertion extends ActionBuilder<dataform.Assertion> { | |||
| this.query(nativeRequire(config.filename).query); | |||
| } | |||
|
|
|||
| // TODO(ekrekr): load config proto column descriptors. | |||
There was a problem hiding this comment.
Why remove this comment in assertion?
There was a problem hiding this comment.
The comment is a lie - columns aren't a field on assertions https://cloud.google.com/dataform/docs/reference/dataform-core-reference#iassertionconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation of these options are locked to the same functionality as before this change via these tests: https://github.com/dataform-co/dataform/blob/b3638a8134f51afdb7afed13d3786b0e2e0e98c9/core/main_test.ts#L1849C11-L1849C25