Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental tables as protos, via a new class #1773

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Jun 28, 2024

Validation of these options are locked to the same functionality as before this change via these tests: https://github.com/dataform-co/dataform/blob/b3638a8134f51afdb7afed13d3786b0e2e0e98c9/core/main_test.ts#L1747C11-L1747C23

@Ekrekr Ekrekr requested review from a team and diasdauletov and removed request for a team June 28, 2024 16:11
Copy link
Contributor

@diasdauletov diasdauletov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ekrekr Ekrekr merged commit 461faf8 into main Jul 7, 2024
4 checks passed
@Ekrekr Ekrekr deleted the incremental-table-configs-as-protos branch July 7, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants