New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1776): dry run of assertions failing #1778

Merged

Ekrekr merged 1 commit into dataform-co:main from ashish10alex:fix_assertions_dry_run

Jul 8, 2024

Contributor

ashish10alex commented Jul 5, 2024

Fixes #1776

The dry of assertion currently fail due to the code expecting the dry run to return at least one row on this line.

Tests

Assertions passing by making the change in the MR. verified by running ./scripts/run run --dry-run <dataform_project_directory>
Assertion when actually ran i.e. using ./scripts/run run ... catches assertion errors
bazel test //core/... passes

PS:
This might not be the best solution, but happy to receive guidance


          fix: dry run of assertions failing

8b3de61

Ekrekr self-requested a review

July 8, 2024 14:42

Ekrekr approved these changes

View reviewed changes

Contributor

Ekrekr left a comment

Thanks for the fix!

Ekrekr merged commit d3d0194 into dataform-co:main

1 of 2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet