Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the stateless CLI package installation error clearer #1795

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Make the stateless CLI package installation error clearer #1795

merged 2 commits into from
Aug 5, 2024

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Aug 5, 2024

Fixes #1749

@Ekrekr Ekrekr requested review from a team and GJMcGowan and removed request for a team August 5, 2024 08:56
@Ekrekr Ekrekr mentioned this pull request Aug 5, 2024
Closed
@Ekrekr Ekrekr requested review from a team, Tuseeq1 and chemerisuk and removed request for GJMcGowan, a team and Tuseeq1 August 5, 2024 08:56
chemerisuk
chemerisuk approved these changes Aug 5, 2024
View reviewed changes
Copy link

@chemerisuk chemerisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ekrekr Ekrekr merged commit 9959bcb into main Aug 5, 2024
4 checks passed
@Ekrekr Ekrekr deleted the make-stateless-install-error-clearer branch August 5, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemerisuk chemerisuk chemerisuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dataform][CLI] - dataform install still looks for package.json even when workflow-settings.yaml is available.
2 participants
@Ekrekr @chemerisuk