Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1805): dry run fails when table/view/assertion already does not exists #1806

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

ashish10alex
Copy link
Contributor

@ashish10alex ashish10alex commented Aug 12, 2024

Solves #1805

  1. Tables/views: For a view / table the metadata need not be set when doing a dry run only query validation is sufficient as metadata cannot be set if the object is not yet being materialised in BigQuery
  2. Assertions: No need to do select sum(1) ... on the view that will be created by the assertion. The query validation is sufficient to establish if the query that will be created is valid.

Tests

  1. Dry run on assertions pass if the query is correct
  2. Dry run on assertion correctly fails if the query is not valid
  3. Dry run on table/view passes if the query is valid
  4. Dry run on table/view correctly fails if the query is not valid
  5. bazel test //core/... passes

Copy link
Contributor

@Ekrekr Ekrekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super helpful, thanks for digging into this and making the PR!

@Ekrekr Ekrekr merged commit 4d20929 into dataform-co:main Sep 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants