-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore ability to unit test views #1824
Conversation
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Co-authored-by: Elias Kassell <eliaskassell@gmail.com>
@Ekrekr I've incorporated both your suggested changes. Is there anything else I need to do before this can be merged? |
Thanks - I've run the tests and they're all good, I just need you to sign the CLA before I can merge. |
@Ekrekr, when I accepted your suggested changes, you became a co-author on that commit, and your @gmail address seems to be missing a signed CLA, so it seems you now need to sign the CLA. Sorry about this, maybe it was a bad idea to use Github's built-in "accept changes" functionality, let me know if you have any ideas for a workaround. |
Huh weird, I see that too, but it also shows as me having already signed it when I follow the link. Will just merge through it! |
Prior to release
3.0.1
, it was possible to unit test views. For example:Such a unit test always fails after
3.0.1
(including3.0.2
). It produces the following error message:Dataset sample_data could not be found
. This happens regardless of whether the view has been defined.This PR re-introduces the ability to unit test views.
I'd like to nominate @Ekrekr as reviewer.