Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct permission and branch name #1845

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Correct permission and branch name #1845

merged 3 commits into from
Sep 14, 2024

Conversation

Tuseeq1
Copy link
Member

@Tuseeq1 Tuseeq1 commented Sep 13, 2024 •
edited
Loading

Correct permissions to run bash scripts for create_gh_pr and update_version.
Fixed name of the branch that is used for PR creation in update_version script to have the same branch name as the npm package version

@Tuseeq1 Tuseeq1 requested review from kolina and Ekrekr September 13, 2024 18:02
kolina
kolina approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@kolina kolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update PR title please because it may not be very clear what permissions and branch name are corrected.

@Tuseeq1 Tuseeq1 merged commit 05341b7 into main Sep 14, 2024
5 checks passed
@Tuseeq1 Tuseeq1 deleted the schedule_pr branch September 14, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolina kolina kolina approved these changes

@Ekrekr Ekrekr Awaiting requested review from Ekrekr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tuseeq1 @kolina