-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Authentication Service Model and Views #3
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ jinja2==3.1.3 | |
pyyaml==6.0.1 | ||
pytest | ||
types-requests | ||
passlib |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
from sqlalchemy import Column, Integer, String, Boolean | ||
|
||
from data.database import Base | ||
|
||
|
||
class User(Base): | ||
__tablename__ = "users" | ||
|
||
id = Column(Integer, primary_key=True, index=True) | ||
tenant_id = Column(Integer, index=True) # Not sure about this one | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Humm.. Name? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And username There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, bear in mind that there are some providers (oAuth) that they don't have any name, just the email . This is OK as emails are unique and you don't need additional unique constrains on the DB. That being said, if you want we can do it optional and if not provided use the email as user-name |
||
email = Column(String, unique=True, index=True) | ||
hashed_password = Column(String) | ||
is_active = Column(Boolean, default=True) | ||
oauth_provider = Column(String, default=None) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
from pydantic import BaseModel | ||
from passlib.context import CryptContext | ||
|
||
from models.authentication import User as UserModel | ||
|
||
pwd_context = CryptContext(schemes=["bcrypt"], deprecated="auto") | ||
|
||
|
||
def get_password_hash(password) -> str: | ||
return pwd_context.hash(password) | ||
|
||
|
||
class UserRequest(BaseModel): | ||
email: str | ||
password: str | ||
|
||
def to_model(self, tenant_id: int, oauth_provider: str) -> UserModel: | ||
return UserModel( | ||
tenant_id=tenant_id, | ||
email=self.email, | ||
hashed_password=get_password_hash(self.password), # TODO: Interline gibberish for extra protection | ||
oauth_provider=oauth_provider, | ||
) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see DH being multi-tenant anytime soon. I would see RBAC fit the bill for most of the things, so I would add Roles"
Having said that, leave it. JIC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will make it nullable and optional so it does not slowdown the implementation