revert changes in rest sink

datahub-project · Jul 2, 2024 · 58dd78d · 58dd78d
1 parent a254b78
commit 58dd78d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 23 deletions.
diff --git a/metadata-ingestion/src/datahub/cli/cli_utils.py b/metadata-ingestion/src/datahub/cli/cli_utils.py
@@ -692,7 +692,7 @@ def generate_access_token(
 
 
 def ensure_mce_has_system_metadata(mce: MetadataChangeEvent) -> None:
-    if not mce.systemMetadata:
+    if mce.systemMetadata is None:
         mce.systemMetadata = SystemMetadataClass()
     mce.systemMetadata.clientId = datahub.__package_name__
     mce.systemMetadata.clientVersion = datahub.__version__
@@ -701,7 +701,7 @@ def ensure_mce_has_system_metadata(mce: MetadataChangeEvent) -> None:
 def ensure_mcp_has_system_metadata(
     mcp: Union[MetadataChangeProposal, MetadataChangeProposalWrapper]
 ) -> None:
-    if not mcp.systemMetadata:
+    if mcp.systemMetadata is None:
         mcp.systemMetadata = SystemMetadataClass()
     mcp.systemMetadata.clientId = datahub.__package_name__
     mcp.systemMetadata.clientVersion = datahub.__version__
diff --git a/metadata-ingestion/src/datahub/emitter/rest_emitter.py b/metadata-ingestion/src/datahub/emitter/rest_emitter.py
@@ -239,6 +239,7 @@ def emit_mce(self, mce: MetadataChangeEvent) -> None:
             system_metadata_obj = {
                 "lastObserved": mce.systemMetadata.lastObserved,
                 "runId": mce.systemMetadata.runId,
+                "lastRunId": mce.systemMetadata.lastRunId,
                 "clientId": mce.systemMetadata.clientId,
                 "clientVersion": mce.systemMetadata.clientVersion,
             }

diff --git a/metadata-ingestion/tests/unit/test_rest_sink.py b/metadata-ingestion/tests/unit/test_rest_sink.py
@@ -75,13 +75,7 @@
                         }
                     }
                 },
-                "systemMetadata": {
-                    "clientId": "acryl-datahub",
-                    "clientVersion": "1!0.0.0.dev0",
-                    "lastObserved": 0,
-                    "lastRunId": "no-run-id-provided",
-                    "runId": "no-run-id-provided",
-                },
+                "systemMetadata": {},
             },
         ),
         (
@@ -131,13 +125,7 @@
                         }
                     }
                 },
-                "systemMetadata": {
-                    "clientId": "acryl-datahub",
-                    "clientVersion": "1!0.0.0.dev0",
-                    "lastObserved": 0,
-                    "lastRunId": "no-run-id-provided",
-                    "runId": "no-run-id-provided",
-                },
+                "systemMetadata": {},
             },
         ),
         (
@@ -173,13 +161,7 @@
                         }
                     }
                 },
-                "systemMetadata": {
-                    "clientId": "acryl-datahub",
-                    "clientVersion": "1!0.0.0.dev0",
-                    "lastObserved": 0,
-                    "lastRunId": "no-run-id-provided",
-                    "runId": "no-run-id-provided",
-                },
+                "systemMetadata": {},
             },
         ),
         (