Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapiv3): v3 scroll response fix #10654

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix(openapiv3): v3 scroll response fix #10654

merged 2 commits into from
Jun 7, 2024

Conversation

david-leifker
Copy link
Collaborator

  • Add skipCache flag
  • Separate v2 and v3 controllers
  • Return entities vs results for v3 per spec
  • Remove aspects nesting for v3 per spec
  • Properly throw error when missing urn field v3
  • Properly throw error when missing urn or aspects field v2

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@david-leifker
fix(openapiv3): v3 scroll response fix
d8fc016 
* Add skipCache flag
* Separate v2 and v3 controllers
* Return `entities` vs `results` for v3 per spec
* Remove `aspects` nesting for v3 per spec
* Properly throw error when missing `urn` field v3
* Properly throw error when missing `urn` or `aspects` field v2
@david-leifker david-leifker mentioned this pull request Jun 6, 2024
Closed
5 tasks
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jun 6, 2024
@david-leifker david-leifker merged commit 1b6763f into master Jun 7, 2024
38 of 39 checks passed
@david-leifker david-leifker deleted the openapi-v3-response-fix branch June 7, 2024 18:37
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@david-leifker @kevin1chun @sleeperdeep
fix(openapiv3): v3 scroll response fix (datahub-project#10654)
59e8d90 
Co-authored-by: Kevin Chun <kevin1chun@gmail.com>
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@david-leifker @kevin1chun @yoonhyejin
fix(openapiv3): v3 scroll response fix (#10654)
156323f 
Co-authored-by: Kevin Chun <kevin1chun@gmail.com>
@kevin1chun kevin1chun mentioned this pull request Jul 22, 2024
Merged
5 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin1chun kevin1chun kevin1chun approved these changes

@RyanHolstien RyanHolstien Awaiting requested review from RyanHolstien

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment publish-docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @kevin1chun