Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patch): consider escaped characters when applying JSON patches #10717

Merged
merged 25 commits into from
Jul 1, 2024
Merged

fix(patch): consider escaped characters when applying JSON patches #10717

merged 25 commits into from
Jul 1, 2024

Conversation

ipolding-cais
Copy link
Contributor

@ipolding-cais ipolding-cais commented Jun 14, 2024 •
edited by coderabbitai bot
Loading

I have raised an issue for this: #10716

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

  • New Features

    • Enhanced handling of special characters in paths for better compatibility.

  • Tests

    • Added tests for JSON patches with special characters to ensure reliable functionality.

@github-actions github-actions bot added the community-contribution PR or Issue raised by member(s) of DataHub Community label Jun 14, 2024
@ipolding-cais ipolding-cais force-pushed the fix-json-patch-edge-case branch 7 times, most recently from 2345821 to 0c83915 Compare June 14, 2024 20:41
@ipolding-cais ipolding-cais mentioned this pull request Jun 17, 2024
Open
@ipolding-cais ipolding-cais changed the title fix: consider escaped characters when applying JSON patches fix(patch): consider escaped characters when applying JSON patches Jun 17, 2024
jjoyce0510
jjoyce0510 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changes, if CI is passing LGTM!

coderabbitai[bot]
coderabbitai bot reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 01f9ee0 and 2d00e6f.

Files selected for processing (1)
  • entity-registry/src/main/java/com/linkedin/metadata/aspect/patch/template/TemplateUtil.java (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • entity-registry/src/main/java/com/linkedin/metadata/aspect/patch/template/TemplateUtil.java

@jjoyce0510
Copy link
Collaborator

Do you mind running ./gradlew entity-registry:spotlessApply to fix the linting CI issue with the test file?

Thanks!

coderabbitai[bot]
coderabbitai bot reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2d00e6f and c136896.

Files selected for processing (1)
  • entity-registry/src/test/java/com/linkedin/metadata/aspect/patch/template/UpstreamLineageTemplateTest.java (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • entity-registry/src/test/java/com/linkedin/metadata/aspect/patch/template/UpstreamLineageTemplateTest.java

@jjoyce0510 jjoyce0510 enabled auto-merge (squash) June 28, 2024 21:04
@ipolding-cais
Copy link
Contributor Author

There was a test failure for unrelated code public void testSslVerificationException() in RestEmitterTest

updating with master and trying again

@jjoyce0510 jjoyce0510 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 28, 2024
@jjoyce0510 jjoyce0510 merged commit 8edc94d into datahub-project:master Jul 1, 2024
34 of 35 checks passed
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@ipolding-cais @jjoyce0510 @yoonhyejin
fix(patch): consider escaped characters when applying JSON patches (#…
b03688c 
…10717)

Co-authored-by: John Joyce <john@acryl.io>
aviv-julienjehannet pushed a commit to aviv-julienjehannet/datahub that referenced this pull request Jul 17, 2024
@ipolding-cais @jjoyce0510 @aviv-julienjehannet
fix(patch): consider escaped characters when applying JSON patches (d…
184e20f 
…atahub-project#10717)

Co-authored-by: John Joyce <john@acryl.io>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipolding-cais @jjoyce0510