Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smoke-test): test access to create/revoke personal access tokens #10848

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

ksrinath
Copy link
Contributor

@ksrinath ksrinath commented Jul 4, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

  • Tests
    • Updated privilege test to verify the ability to create and revoke personal access tokens instead of managing access tokens.

Copy link
Contributor

coderabbitai bot commented Jul 4, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

The primary change involves renaming a test function and updating the associated privilege in the test. The test function test_privilege_to_create_and_manage_access_tokens is now test_privilege_to_create_and_revoke_personal_access_tokens, and the privilege MANAGE_ACCESS_TOKENS has been updated to GENERATE_PERSONAL_ACCESS_TOKENS.

Changes

File Change Summary
smoke-test/tests/privileges/test_privileges.py Renamed test function and updated privilege name in the implementation.

Sequence Diagram(s)

Skipping sequence diagram generation as the changes are too simple and do not alter the control flow significantly.

Poem

Amidst the code where tokens unfold,
A rabbit's tale of changes told.
With names renewed, permissions bright,
Creating tokens feels just right.
Revoke, create, in test's embrace,
Simplified flows, a joyous space!
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added smoke_test Contains changes related to smoke tests community-contribution PR or Issue raised by member(s) of DataHub Community labels Jul 4, 2024
@ksrinath ksrinath closed this Jul 4, 2024
@ksrinath ksrinath reopened this Jul 4, 2024
@anshbansal
Copy link
Collaborator

Nested domains smoke test is flaky. Another dev is working to fix that.

@anshbansal anshbansal merged commit ae9f1fb into datahub-project:master Jul 4, 2024
35 of 36 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants