-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: optimize layers #10859
base: master
Are you sure you want to change the base?
docker: optimize layers #10859
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
COPY ./docker/monitoring/client-prometheus-config.yaml /datahub-frontend/ | ||
RUN chown -R datahub:datahub /datahub-frontend && chmod 755 /datahub-frontend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be an out of order issue here. If the chown/chmod was expected to apply to the config file, it is no longer. I'd move the COPY above
@@ -69,8 +73,6 @@ FROM ${APP_ENV}-install as final | |||
|
|||
RUN mkdir -p /etc/datahub/plugins/auth/resources | |||
|
|||
RUN addgroup -S datahub && adduser -S datahub -G datahub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer being applied to dev-install, this is probably a regression.
Just noticed this one... perhaps #10878 can be made part of this? |
Checklist