fix/ added click to perticular result and delay to element visibility

[Kunal-kankriya]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• Bug Fixes
  • Improved auto-complete functionality by selecting options based on their text content.
  • Added a visibility check for table rows to enhance user interaction reliability.

[coderabbitai]

Walkthrough

The recent updates to the auto_complete.js file enhance the auto-complete functionality by selecting options based on their text content rather than defaulting to the first option. Additionally, a visibility check for elements with the class .ant-table-row has been implemented to ensure the interface behaves as expected during interactions.

Changes

File Path	Change Summary
...cypress/cypress/e2e/auto_complete/auto_complete.js	Modified auto-complete behavior to select based on text content and added a visibility check for .ant-table-row.

Poem

In the code, a change was made,
Auto-complete now better played 🎵,
First one it picks no more,
Text it seeks, to find the score.
With rows in view, tests now pave,
A path of smooth, where errors waive.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 97638c3 and 3848af1.

Files selected for processing (1)

• smoke-test/tests/cypress/cypress/e2e/auto_complete/auto_complete.js (1 hunks)

Additional comments not posted (5)

smoke-test/tests/cypress/cypress/e2e/auto_complete/auto_complete.js (5)

Line range hint 1-15:
LGTM!

The function comprehensively tests the auto-complete functionality by typing in different search queries and verifying the results.

---

32-32: Ensure element visibility check is necessary.

The visibility check for .ant-table-row might be redundant if the URL check is already confirming the navigation.

Is the visibility check for .ant-table-row necessary if the URL check is already confirming the navigation?

---

Line range hint 34-47:
LGTM!

The function comprehensively tests the auto-complete result filtering when a quick filter is clicked.

---

Line range hint 49-60:
LGTM!

The function comprehensively tests the search result filtering when searching with a quick filter selected.

---

29-31: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to cy.get('[data-testid^="auto-complete-option"]') match the expected behavior.