fix(ingest/test): Fix for mssql integration tests

[treff7es]

Fixing sqlcmd location for mssql integration tests

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• Bug Fixes
  • Updated the path for the SQL command-line tool and added an option to improve compatibility with the latest version, enhancing the reliability of integration tests.

[coderabbitai]

Walkthrough

The recent update to the test_sql_server.py file involves changing the path for the sqlcmd tool used in the mssql_runner function. The new path reflects an upgrade to version 18 of the SQL Server command-line tools, ensuring compatibility with the latest features. Additionally, the -C option was added for improved functionality. Despite these changes, the core functionality of executing a SQL script for database setup remains intact.

Changes

Files	Change Summary
metadata-ingestion/tests/integration/sql_server/test_sql_server.py	Updated sqlcmd tool path from /opt/mssql-tools/bin/sqlcmd to /opt/mssql-tools18/bin/sqlcmd and added -C option for enhanced functionality.

Poem

🐇 In the land of code, where the databases bloom,
A path was shifted, making room!
With sqlcmd fresh and new in sight,
Our tests run smoothly, oh what a delight!
Hopping through code, with a cheer and a dance,
Upgrading the tools gives our functions a chance! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f0f226c and ce3e3ea.

Files selected for processing (1)

• metadata-ingestion/tests/integration/sql_server/test_sql_server.py (1 hunks)

Additional comments not posted (1)

metadata-ingestion/tests/integration/sql_server/test_sql_server.py (1)

25-25: Verify the new path for sqlcmd.

The path to the sqlcmd tool has been updated to /opt/mssql-tools18/bin/sqlcmd. Ensure that this path is valid and that the necessary tools are installed in the specified location.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ce3e3ea and 3c0efd8.

Files selected for processing (1)

• metadata-ingestion/tests/integration/sql_server/test_sql_server.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• metadata-ingestion/tests/integration/sql_server/test_sql_server.py