-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest/graph): Update get_results_by_filter graphql query #10991
fix(ingest/graph): Update get_results_by_filter graphql query #10991
Conversation
WalkthroughThe recent changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- metadata-ingestion/src/datahub/ingestion/graph/client.py (2 hunks)
Additional comments not posted (2)
metadata-ingestion/src/datahub/ingestion/graph/client.py (2)
929-930
: Clarify the Acryl Cloud support note.The note in the docstring clarifies that the function is only supported with Acryl Cloud. This is a helpful addition for users.
996-999
: Verify the addition ofextraProperties
in the return structure.The inclusion of
extraProperties
in the GraphQL query is correct. Ensure that the additional fields (name
andvalue
) are handled properly in the consuming code.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes