Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emitter): fix typo in get method of java kafka emitter #11007

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

rtekal
Copy link
Contributor

@rtekal rtekal commented Jul 26, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the method name for retrieving Kafka configuration properties, improving clarity and maintainability.

Copy link
Contributor

coderabbitai bot commented Jul 26, 2024

Walkthrough

The recent change involves correcting a typographical error in the KafkaEmitter class by renaming the method getKafkaConfgiProperties() to getKafkaConfigProperties(). This adjustment improves clarity and maintainability without altering the method’s functionality. The change ensures that the method name accurately represents its purpose of retrieving Kafka configuration properties.

Changes

Files Change Summary
.../datahub/client/kafka/KafkaEmitter.java Renamed getKafkaConfgiProperties() to getKafkaConfigProperties() to correct a typographical error.

Poem

🐇 In the code where rabbits play,
A typo hopped and lost its way.
With a name now bright and clear,
We fetch configs without fear!
Let’s celebrate this little fix,
A leap of joy in our code mix! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community datahub-community-champion PRs authored by DataHub Community Champions labels Jul 26, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 82412e7 and e987502.

Files selected for processing (1)
  • metadata-integration/java/datahub-client/src/main/java/datahub/client/kafka/KafkaEmitter.java (1 hunks)
Files skipped from review due to trivial changes (1)
  • metadata-integration/java/datahub-client/src/main/java/datahub/client/kafka/KafkaEmitter.java

@rtekal
Copy link
Contributor Author

rtekal commented Aug 2, 2024

Let me know if there are any questions to approve/merge this PR. Thank you.

@rtekal
Copy link
Contributor Author

rtekal commented Aug 2, 2024

The method name has a typo: getKafkaConfgiProperties
Change it to Config

@hsheth2 hsheth2 changed the title (fix) Typo in get method fix(emitter): fix typo in get method of java kafka emitter Aug 6, 2024
@hsheth2 hsheth2 merged commit 090e760 into datahub-project:master Aug 6, 2024
33 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community datahub-community-champion PRs authored by DataHub Community Champions ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants