fix(ingestion/lookml): fix for sql parsing error #11079
Conversation
WalkthroughThe recent updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
the
ingestion
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- metadata-ingestion/setup.py (1 hunks)
Additional comments not posted (1)
metadata-ingestion/setup.py (1)
102-102: Dependency Update Approved. Verify compatibility with the new version.The version of the
acryl-sqlglotlibrary has been updated from25.3.1.dev3to25.8.2.dev9. Ensure that the new version does not introduce any breaking changes or compatibility issues.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- metadata-ingestion/tests/unit/sql_parsing/goldens/test_bigquery_information_schema_query.json (1 hunks)
- metadata-ingestion/tests/unit/sql_parsing/goldens/test_merge_from_union.json (2 hunks)
Files skipped from review due to trivial changes (1)
- metadata-ingestion/tests/unit/sql_parsing/goldens/test_bigquery_information_schema_query.json
Additional comments not posted (2)
metadata-ingestion/tests/unit/sql_parsing/goldens/test_merge_from_union.json (2)
4-4: Query fingerprint update is appropriate.The change in
query_fingerprintreflects an update to the SQL query structure, which is expected when the query changes.
15-15: Generalized statement modification is acceptable.The change in the case of the
timestampfunction likely aligns with style guidelines or consistency preferences. Ensure compatibility with the SQL dialect in use, as case sensitivity can vary.
hsheth2
added
the
merge-pending-ci
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- metadata-ingestion/tests/unit/sql_parsing/goldens/test_bigquery_information_schema_query.json (2 hunks)
- metadata-ingestion/tests/unit/sql_parsing/test_sqlglot_lineage.py (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- metadata-ingestion/tests/unit/sql_parsing/goldens/test_bigquery_information_schema_query.json
Additional comments not posted (1)
metadata-ingestion/tests/unit/sql_parsing/test_sqlglot_lineage.py (1)
1191-1191: Verify the context and aliasing forcfp.field_path.The change from
field_pathtocfp.field_pathin the CASE statement should be verified to ensure it aligns with the intended data structure or aliasing. This change might affect howdata_typeis evaluated and could impact the test's accuracy.Verification successful
Verification Successful: Consistent Use of
cfp.field_pathThe change to use
cfp.field_pathin the test file aligns with the source file's SQL query structure, ensuring consistency in aliasing and data structure. No issues are found with this modification.
- The change is consistent with the usage in
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/queries.py.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage and context of `cfp.field_path` in the codebase. # Test: Search for the usage of `cfp.field_path`. Expect: Correct context and aliasing in SQL queries. rg --type python -A 5 $'cfp.field_path'Length of output: 69
Script:
#!/bin/bash # Description: Verify the usage and context of `cfp.field_path` in the codebase. # Test: Search for the usage of `cfp.field_path`. Expect: Correct context and aliasing in SQL queries. rg -t py -A 5 $'cfp.field_path'Length of output: 3891
It has fix for error
AttributeError: 'NoneType' object has no attribute 'replace'Summary by CodeRabbit