-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion/looker): filter Looker dashboards by folder #11205
Changes from 2 commits
46e4436
b02befc
d28cef3
9aaf12c
5983c3b
75ee8ef
f83fe76
f1c6e82
ed23a63
0570686
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -298,6 +298,17 @@ class LookerDashboardSourceConfig( | |
description="When enabled, platform instance will be added in dashboard and chart urn.", | ||
) | ||
|
||
folder_path_pattern: AllowDenyPattern = Field( | ||
default=AllowDenyPattern.allow_all(), | ||
description="Filter for specific looker folder. " | ||
"For example: \n" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This comment is super long. I'll let Harshal decide what to do here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
"deny: \n" | ||
" - sales/deprecated \n" | ||
"This pattern will deny the ingestion of all dashboards and looks within the sales/deprecated folder." | ||
"This pattern is applied after dashboard_pattern. Dashboards selected by `dashboard_pattern` may be denied " | ||
"based on `folder_path_pattern`.", | ||
) | ||
|
||
@validator("external_base_url", pre=True, always=True) | ||
def external_url_defaults_to_api_config_base_url( | ||
cls, v: Optional[str], *, values: Dict[str, Any], **kwargs: Dict[str, Any] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Say "Allow or deny dashboards from specific folders"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done