Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gms): filter out runs of a dataJob without any run-events #11223

Merged
merged 19 commits into from
Sep 11, 2024
Merged

fix(gms): filter out runs of a dataJob without any run-events #11223

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1d844bb
fix(gms): filter out runs of a dataJob without any run-events
ksrinath Aug 22, 2024
043f697
Merge branch 'master' into fix/filter-runs-without-state
ksrinath Aug 22, 2024
827fee4
perf improvement, comments on pagination behavior
ksrinath Aug 23, 2024
93b261f
updated implementation, filtering on a new hasRunEvents field
ksrinath Aug 28, 2024
bb10b02
spotless
ksrinath Aug 28, 2024
cfcd688
spotless
ksrinath Aug 28, 2024
42b54cd
simply add searchable annotation in pdl instead of creating a new hook
ksrinath Aug 28, 2024
4fb5e8c
misc fix
ksrinath Aug 28, 2024
f158490
WIP backfilling dataProcessInstances
ksrinath Aug 30, 2024
df1e6e8
reprocess-flag, config parameters
ksrinath Sep 2, 2024
fa480cc
Merge branch 'master' into fix/filter-runs-without-state
ksrinath Sep 2, 2024
4c41415
misc fix
ksrinath Sep 2, 2024
b61c65a
Merge branch 'master' into fix/filter-runs-without-state
ksrinath Sep 5, 2024
140082a
fix compile errors due to upstream changes; misc.
ksrinath Sep 5, 2024
dd798f3
add batchDelayMs to throttle aggregation query
ksrinath Sep 5, 2024
1795d50
Merge branch 'master' into fix/filter-runs-without-state
ksrinath Sep 6, 2024
1b2f733
Merge branch 'master' into fix/filter-runs-without-state
ksrinath Sep 10, 2024
72cc63a
time-window filtering and capped history
ksrinath Sep 10, 2024
5098697
Merge branch 'master' into fix/filter-runs-without-state
ksrinath Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...l-core/src/main/java/com/linkedin/datahub/graphql/resolvers/jobs/DataJobRunsResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
import com.linkedin.common.urn.Urn;
import com.linkedin.datahub.graphql.QueryContext;
import com.linkedin.datahub.graphql.concurrency.GraphQLConcurrencyUtils;
import com.linkedin.datahub.graphql.generated.DataProcessInstance;
import com.linkedin.datahub.graphql.generated.DataProcessInstanceResult;
import com.linkedin.datahub.graphql.generated.Entity;
import com.linkedin.datahub.graphql.generated.*;
import com.linkedin.datahub.graphql.types.dataprocessinst.mappers.DataProcessInstanceMapper;
import com.linkedin.entity.EntityResponse;
import com.linkedin.entity.client.EntityClient;
Expand All @@ -33,13 +31,17 @@
import java.util.Objects;
import java.util.concurrent.CompletableFuture;
import java.util.stream.Collectors;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/** GraphQL Resolver used for fetching a list of Task Runs associated with a Data Job */
public class DataJobRunsResolver
implements DataFetcher<CompletableFuture<DataProcessInstanceResult>> {

private static final String PARENT_TEMPLATE_URN_SEARCH_INDEX_FIELD_NAME = "parentTemplate";
private static final String CREATED_TIME_SEARCH_INDEX_FIELD_NAME = "created";
private static final String HAS_RUN_EVENTS_FIELD_NAME = "hasRunEvents";
private static final Logger log = LoggerFactory.getLogger(DataJobRunsResolver.class);

private final EntityClient _entityClient;

Expand Down Expand Up @@ -117,7 +119,12 @@ private Filter buildTaskRunsEntityFilter(final String entityUrn) {
new Criterion()
.setField(PARENT_TEMPLATE_URN_SEARCH_INDEX_FIELD_NAME)
.setCondition(Condition.EQUAL)
.setValue(entityUrn)));
.setValue(entityUrn),
new Criterion()
.setField(HAS_RUN_EVENTS_FIELD_NAME)
.setCondition(Condition.EQUAL)
.setValue(Boolean.TRUE.toString())));

final Filter filter = new Filter();
filter.setOr(
new ConjunctiveCriterionArray(ImmutableList.of(new ConjunctiveCriterion().setAnd(array))));
Expand Down
4 changes: 4 additions & 0 deletions metadata-models/src/main/pegasus/com/linkedin/dataprocess/DataProcessInstanceRunEvent.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ import com.linkedin.common.Urn
record DataProcessInstanceRunEvent includes TimeseriesAspectBase, ExternalReference {

@TimeseriesField = {}
@Searchable = {
"fieldType": "TEXT",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either be removed or set to KEYWORD. The reason is that the value is of type enum which would default to KEYWORD.

"hasValuesFieldName": "hasRunEvents"
}
status: enum DataProcessRunStatus {
/**
* The status where the Data processing run is in.
Expand Down
Loading