Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(javaEntityClient): correct config parameter #12287

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix(javaEntityClient): correct config parameter #12287

merged 1 commit into from
Jan 8, 2025

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jan 7, 2025
@david-leifker david-leifker changed the title fix(batch-ingest-config): java entity client batch ingest config fix(javaEntityClient): correct config parameter Jan 7, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 7, 2025
@david-leifker david-leifker force-pushed the fix-batch-ingest-size-param branch from b3d87a1 to 22869a2 Compare January 8, 2025 02:07
sgomezvillamor
sgomezvillamor approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 8, 2025
@david-leifker david-leifker merged commit 98a5a2c into datahub-project:master Jan 8, 2025
100 of 101 checks passed
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@david-leifker @llance
fix(javaEntityClient): correct config parameter (datahub-project#12287)
664c835
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@david-leifker @llance
fix(javaEntityClient): correct config parameter (datahub-project#12287)
3a23650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @sgomezvillamor