Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ingest/glue): add permissions for glue #12290

Merged
merged 3 commits into from
Jan 10, 2025
Merged

docs(ingest/glue): add permissions for glue #12290

merged 3 commits into from
Jan 10, 2025

Conversation

anshbansal
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 8, 2025
@anshbansal anshbansal marked this pull request as ready for review January 9, 2025 09:53
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 9, 2025
@anshbansal anshbansal force-pushed the ab-08-jan-2025-glue-permissions branch from 0fcded2 to 0a17c09 Compare January 9, 2025 13:01
sgomezvillamor
sgomezvillamor approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit a92a107 into master Jan 10, 2025
80 checks passed
@anshbansal anshbansal deleted the ab-08-jan-2025-glue-permissions branch January 10, 2025 10:54
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
...ingestion/src/datahub/ingestion/source/aws/glue.py 88.13% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b2cd3...0a17c09. Read the comment docs.

llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@anshbansal @llance
docs(ingest/glue): add permissions for glue (datahub-project#12290)
1fff8b3
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@anshbansal @llance
docs(ingest/glue): add permissions for glue (datahub-project#12290)
38fd338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @sgomezvillamor