Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/gc): add delete limit execution request #12313

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

anshbansal
Copy link
Collaborator

  • Add deletion limit execution request
  • Add missing fields from template

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata devops PR or Issue related to DataHub backend & deployment labels Jan 10, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...b/ingestion/source/gc/execution_request_cleanup.py 0.00% 19 Missing ⚠️
...ingestion/source/gc/soft_deleted_entity_cleanup.py 0.00% 5 Missing ⚠️
Files with missing lines Coverage Δ
...ingestion/source/gc/soft_deleted_entity_cleanup.py 45.39% <0.00%> (-1.44%) ⬇️
...b/ingestion/source/gc/execution_request_cleanup.py 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b827f3...75ff6a1. Read the comment docs.

Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit a4f5ab4 into master Jan 10, 2025
200 of 231 checks passed
@anshbansal anshbansal deleted the ab-2025-jan-10-add-delete-limit branch January 10, 2025 10:54
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants