Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/delete): prevent duplicates in delete message #12323

Merged
merged 2 commits into from
Jan 13, 2025
Merged

fix(cli/delete): prevent duplicates in delete message #12323

merged 2 commits into from
Jan 13, 2025

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 10, 2025

random.choice picks with replacement, but we want a sample that does not have
duplicates.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(cli/delete): prevent duplicates in delete message
dc5171e 
`random.choice` picks with replacement, but we want a sample that does not have
duplicates.
@hsheth2
fix other usage
7c6b6e6
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 10, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
metadata-ingestion/src/datahub/cli/migrate.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
metadata-ingestion/src/datahub/cli/delete_cli.py 31.88% <100.00%> (ø)
metadata-ingestion/src/datahub/cli/migrate.py 18.96% <0.00%> (ø)

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9897804...7c6b6e6. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 10, 2025
shirshanka
shirshanka approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 12, 2025
@hsheth2 hsheth2 merged commit 8d48622 into master Jan 13, 2025
239 of 251 checks passed
@hsheth2 hsheth2 deleted the delete-cli-choice branch January 13, 2025 06:09
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@hsheth2 @llance
fix(cli/delete): prevent duplicates in delete message (datahub-projec…
c40c15c 
…t#12323)
llance pushed a commit to llance/datahub that referenced this pull request Jan 13, 2025
@hsheth2 @llance
fix(cli/delete): prevent duplicates in delete message (datahub-projec…
b3d38f0 
…t#12323)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka