Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs-website): bump docusaurus to v2.1.0 #5792

Merged
merged 8 commits into from
Sep 20, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 31, 2022

Dropped our custom color mode switcher because the new docusuarus one looks pretty good:
color picker

Renaming our imports because of these PR changes. We have to rely on some "internal" imports which isn't ideal :(

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

],
},
// {
// "Advanced Tutorials": [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maggiehays fyi - these sections weren't showing up in the sidebar before either, but now docusaurus complains about them so I commented them out

@github-actions
Copy link

github-actions bot commented Aug 31, 2022

Unit Test Results (build & test)

562 tests  ±0   562 ✔️ ±0   12m 43s ⏱️ -17s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ±0 

Results for commit 9b9fa56. ± Comparison against base commit 4062385.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal added the docs Issues and Improvements to docs label Sep 8, 2022
@hsheth2 hsheth2 changed the title chore(docs-website): bump docusaurus to v2.0.1 chore(docs-website): bump docusaurus to v2.1.0 Sep 19, 2022
@hsheth2 hsheth2 merged commit 26bca9e into datahub-project:master Sep 20, 2022
@hsheth2 hsheth2 deleted the docusaurus-bump branch September 20, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants