docs: lint all md files, add docs #45
Conversation
|
Thanks @cyril-corbon LGTM. @itamar-marom do cross-review this PR, thanks. |
cyril-corbon
force-pushed
the
docs/update-docs-and-lint
branch
from
f9bf8c2
to
ee495f9
Compare
|
@cyril-corbon why did the manager flags change? is it a Kubebuilder change or a custom change of ours? I want to avoid any unnecessary customizations we have (or operator SDK code). Regarding namespace change - It's tricky since Kubebuilder generates the namespace as "druid-operator-system". That means that any time we will re-generate the CRDs we will need to take care of it. BTW this is also a customization that separates us from Kubebuilder best practices. |
|
BTW i did build the current master before cutting v1.1.0 , the charts LGTM |
for the flag it was due to a miss configuration on my side, I'll revert this change. |
SGTM |
cyril-corbon
force-pushed
the
docs/update-docs-and-lint
branch
from
ee495f9
to
4675cb5
Compare
docs/features.md
Outdated
| - ```NOTE: User must be aware of this feature, there might be cases where crashloopback might be caused due probe failure, fault image etc, the operator shall keep on deleting on each re-concile loop. Default Behavior is True ``` | ||
|
|
||
| ## Scaling of Druid Nodes | ||
| - Operator supports ```HPA autosaling/v2beta2``` Spec in the nodeSpec for druid nodes. In case HPA deployed, HPA controller maintains the replica count/state for the particular statefulset referenced. Refer to ```examples.md``` for HPA configuration. | ||
|
|
||
| - Operator supports ```HPA autosaling/v2beta2``` Spec in the nodeSpec for druid nodes. In case HPA deployed, HPA controller maintains the replica count/state for the particular statefulset referenced. Refer to ```examples.md``` for HPA configuration. |
There was a problem hiding this comment.
| - Operator supports ```HPA autosaling/v2beta2``` Spec in the nodeSpec for druid nodes. In case HPA deployed, HPA controller maintains the replica count/state for the particular statefulset referenced. Refer to ```examples.md``` for HPA configuration. | |
| - Operator supports ```HPA autosaling/v2``` Spec in the nodeSpec for druid nodes. In case HPA deployed, HPA controller maintains the replica count/state for the particular statefulset referenced. Refer to ```examples.md``` for HPA configuration. |
Signed-off-by: Cyril Corbon <cyril.corbon@dailymotion.com>
cyril-corbon
force-pushed
the
docs/update-docs-and-lint
branch
from
4675cb5
to
6b7f930
Compare
|
@cyril-corbon @AdheipSingh why aren't we merging this? |
| runAsNonRoot: true | ||
| fsGroup: 65532 | ||
| runAsUser: 65532 | ||
| runAsGroup: 65532 | ||
|
|
There was a problem hiding this comment.
why do we need this ? can we know the exact reason
There was a problem hiding this comment.
it was to match the user / group defined in the Dockerfile of the Operator here: https://github.com/cyril-corbon/druid-operator/blob/master/Dockerfile#L31
I also note this :
set user / group / fsuser or the operator crash in 1.26
but I cannot reproduce it anymore
There was a problem hiding this comment.
IMHO It's a good idea to set theses values by default.
both containers of the pod have the same uid/gid so it should not be an issue to set this at pod level.
docker history gcr.io/kubebuilder/kube-rbac-proxy:v0.13.1
IMAGE CREATED CREATED BY SIZE COMMENT
60cb20b77a0f 9 months ago /bin/sh -c #(nop) ENTRYPOINT ["/usr/local/b… 0B
<missing> 9 months ago /bin/sh -c #(nop) USER 65532:65532 0B
I can remove it if you want or if you think it's not useful 😄
There was a problem hiding this comment.
make sense.
its only related to kube rbac proxy container right ? not the druid-operator ?
There was a problem hiding this comment.
it's related to both containers. its not an issue as they share the same uid / gid
|
@AdheipSingh @cyril-corbon Are we merging it? After that, we can release the new version we wanted |
Description
This PR has:
Key changed/added files in this PR
MyFooOurBarTheirBaz