Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): changing rollingUpdate default to true #83

Merged

Conversation

itamar-marom
Copy link
Collaborator

@itamar-marom itamar-marom commented Jul 8, 2023

Fixes #81

Description

Druid requires a rolling update in order to apply changes with no downtime. The operator supports it with the rollingUpdate field.
Currently, this behavior is disabled by default for no reason.
This PR changes Druid's API rollingUpdate field to be true by default. This is done by using a Kubebuilder marker.


This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Key changed/added files in this PR
  • apis/druid/v1alpha1/druid_types.go

Changing Druid's API `rollingUpdate` field to by true by default.
@itamar-marom
Copy link
Collaborator Author

itamar-marom commented Jul 8, 2023

This might be considered as a breaking change since users using the default rollingUpdate will now need to set it.

@itamar-marom itamar-marom marked this pull request as draft July 8, 2023 20:27
@itamar-marom itamar-marom marked this pull request as ready for review July 8, 2023 20:31
@itamar-marom itamar-marom merged commit e4f9327 into datainfrahq:master Jul 9, 2023
1 check passed
@itamar-marom itamar-marom deleted the feat/default-rolling-update branch July 9, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator does not seem to respect the recommended upgrade order
2 participants