Fix fetchn on queries with zero results #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update release log
dimitri-yatsenko
approved these changes
Mar 16, 2021
ixcat
reviewed
Apr 27, 2021
| @@ -289,7 +289,8 @@ function clip(self) | |||
| for iArg=1:length(specs) | |||
| % if renamed, use the renamed attribute | |||
| name = regexp(specs{iArg}, '(\w+)\s*$', 'tokens'); | |||
| if isnumeric(s(1).(name{1}{1})) && length(s(1).(name{1}{1})) == 1 | |||
| sel = cellfun(@(x) strcmp(x, name{1}{1}), {self.header.attributes.name}); | |||
| if self.tableHeader.attributes(sel).isNumeric | |||
There was a problem hiding this comment.
this may have introduced a regression - received a report elsewhere:
To fix the bug I changed:
In dj.internal.GeneralRelvar (line 293) I changed
if self.tableHeader.attributes(sel).isNumeric
to
if self.header.attributes(sel).isNumeric
There was a problem hiding this comment.
looks like this has been filed as an issue in: #364; disregard discussion here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on datajoint/mysql-docker#29
Fix #353
Fix #352