-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Diagram.make_dot for pydot 3.* compatibility #1177
Conversation
Before running `to_pydot`, we encapsulate node names and attr_map in double quotes to avoid syntax errors when the node names contain special characters. Implements the workarounds described in #1176 (comment) and pydot/pydot#258 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tabedzki Could you review? If approved, we can merge into your PR to keep the issue board clean.
@ethho This looks good from first glance. I'll try to check this sometime over the weekend/monday to confirm that this works and get back to you on this. Thank you for addressing this so quickly. |
Sure thing, thank you @tabedzki for doing the heavy lifting of investigating! |
@ethho re-running the same example that I used for #1176, this works without requiring the latest version of I'd say all that is left is to update the change log and list out all the issues here that this PR closes so clear up some of the backlog. I'll close my PR. Package versions: DOT representation of the graph truncated:
|
Encapsulates node names and edge attribute
attr_map
in double quotes before callingto_pydot
in methodDiagram.make_dot
. Partially duplicates changes made in #1176.Closes #1175 and closes #1169 and closes #1100 and closes #1065. May close related issue #1072.