Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/ppbnumber-issues. #79

Merged
merged 12 commits into from
Mar 28, 2024
Merged

Fixes/ppbnumber-issues. #79

merged 12 commits into from
Mar 28, 2024

Conversation

ananjaykumar2
Copy link
Contributor

this PR includes:

  • ppbNumber reated changes
  • code coverage 90%
  • separate postman collection for adex

@jenkins-datakaveri
Copy link

Can one of the admins verify this patch?

@ananjaykumar2 ananjaykumar2 changed the title Fixes/ppbnumber-ssues. Fixes/ppbnumber-issues. Mar 21, 2024
@pranavrd
Copy link
Contributor

ok to test

@jenkins-datakaveri
Copy link

Build finished.

@pranavv0
Copy link
Contributor

retest this please

@jenkins-datakaveri
Copy link

Build finished.

@pranavv0
Copy link
Contributor

retest this please

@jenkins-datakaveri
Copy link

Build finished.

4 similar comments
@jenkins-datakaveri
Copy link

Build finished.

@jenkins-datakaveri
Copy link

Build finished.

@jenkins-datakaveri
Copy link

Build finished.

@jenkins-datakaveri
Copy link

Build finished.

@pranavv0
Copy link
Contributor

retest this please

@jenkins-datakaveri
Copy link

Build finished.

@pranavv0
Copy link
Contributor

retest this please

@jenkins-datakaveri
Copy link

Build finished.

2 similar comments
@jenkins-datakaveri
Copy link

Build finished.

@jenkins-datakaveri
Copy link

Build finished.

@pranavv0
Copy link
Contributor

retest this please

@jenkins-datakaveri
Copy link

Build finished.

@jenkins-datakaveri
Copy link

Build finished.

@pranavv0
Copy link
Contributor

lgtm. Pipeline is passing.

pranavv0
pranavv0 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@pranavv0 pranavv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitmashu ankitmashu self-requested a review March 28, 2024 08:41
ankitmashu
ankitmashu approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@ankitmashu ankitmashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pranavrd pranavrd merged commit a36f7c4 into datakaveri:main Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitmashu ankitmashu ankitmashu approved these changes

@pranavv0 pranavv0 pranavv0 approved these changes

@pranavrd pranavrd pranavrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ananjaykumar2 @jenkins-datakaveri @pranavrd @pranavv0 @ankitmashu