Adding self test for the get_memory function #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JanPeterDatakind
commented
Jul 5, 2024
JanPeterDatakind
commented
- This test specifically tests the retrieval of memories from the recipe db via the recipe server/ fast API
- Test Cases cover: Successful retrieval of text-based memories, successful retrieval of images (checks if the correct url to where the image is served is returned), message that no memory was found
- Test cases can easily be added or modified by adding to the test_cases_get_memory.json file
|
Looks great, nice one. Will approve even though e2e broken, I need to fix the latter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.