Add docker build var to spoof git tag version #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
=======================================
Coverage 68.49% 68.49%
=======================================
Files 62 62
Lines 3955 3955
=======================================
Hits 2709 2709
Misses 1246 1246 |
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/fix-fake-api-version
|
| Run status |
|
| Run duration | 06m 21s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
405
|
| View all changes introduced in this branch ↗︎ | |
|
I've tested this on yellowhammer, so will merge when the final tests pass again |
ml-evs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if the version of datalab is being installed from a git submodule, or a worktree, it is impossible to set the API version. For the app, we can override this with the
VUE_APP_GIT_VERSION. For the API, we have to use theSETUPTOOLS_SCM_PRETEND_SCM_VERSION. This PR passes that value through the build system to make it available whenuvinstalls.