Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vue-loader errors #1004

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix vue-loader errors #1004

merged 2 commits into from
Nov 13, 2024

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Nov 13, 2024

Add missing <tbody> or <tr> inside components/BatchCreateItemModal.vue, components/StatisticsTable.vue & views/About.vue

@BenjaminCharmes BenjaminCharmes force-pushed the bc/fix-vue-loader-errors branch from bec0d59 to 142b9f8 Compare November 13, 2024 11:47
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (a968b54) to head (0dd0f80).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files          62       62           
  Lines        3955     3955           
=======================================
  Hits         2709     2709           
  Misses       1246     1246           

Copy link

cypress bot commented Nov 13, 2024

datalab    Run #2771

Run Properties:  status check passed Passed #2771  •  git commit 829fe72b89 ℹ️: Merge 0dd0f80d3fc831b1cc3e1fb8dbd23b107f1c7296 into a968b5475258d8235c9cad87649e...
Project datalab
Branch Review bc/fix-vue-loader-errors
Run status status check passed Passed #2771
Run duration 06m 30s
Commit git commit 829fe72b89 ℹ️: Merge 0dd0f80d3fc831b1cc3e1fb8dbd23b107f1c7296 into a968b5475258d8235c9cad87649e...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 405
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review November 13, 2024 12:25
Copy link
Member

@jdbocarsly jdbocarsly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this

@jdbocarsly jdbocarsly merged commit 24bb0f9 into main Nov 13, 2024
24 checks passed
@jdbocarsly jdbocarsly deleted the bc/fix-vue-loader-errors branch November 13, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants