Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better layouts and configuration options to the Item Graph #813

Merged
merged 18 commits into from
Nov 27, 2024

Conversation

jdbocarsly
Copy link
Member

@jdbocarsly jdbocarsly commented Jul 18, 2024

Todo:

  • Add menu for graph configuration options
  • Add ability to ignore user-selected items and collections (use case: to avoid the graph clumping around trivial starting materials that are used in a large number of items)
  • Add option to show starting material names instead of ids
  • Add option to show sample/cell names instead of ids
  • Improve choice of graph algorithms to improve speed
  • Fix error ctr is not defined when the graph is generated, then returned to.
  • Make item and collection ignore dynamic (instead of regenerating the graph each time)
  • Add button to not show any collections (deferred)
  • Dynamically change labels (instead of regenerating the graph)
  • Some options for coloring/styling the nodes (deferred)
  • pre-populate the ItemSelect with the highest rank starting materials, since these are the most likely to need to be removed (deferred)

@jdbocarsly jdbocarsly force-pushed the jdb/item-graph-configuration branch from 4570bdb to 50fc5a1 Compare July 25, 2024 14:29
Copy link

cypress bot commented Aug 1, 2024

datalab    Run #2814

Run Properties:  status check passed Passed #2814  •  git commit b5b1335988 ℹ️: Merge 547f9d85cb187aee3a5c2f20c9bbbd712211308c into 691f1046395d15e0acc44d82454f...
Project datalab
Branch Review jdb/item-graph-configuration
Run status status check passed Passed #2814
Run duration 06m 30s
Commit git commit b5b1335988 ℹ️: Merge 547f9d85cb187aee3a5c2f20c9bbbd712211308c into 691f1046395d15e0acc44d82454f...
Committer Josh Bocarsly
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 405
View all changes introduced in this branch ↗︎

@jdbocarsly jdbocarsly force-pushed the jdb/item-graph-configuration branch from 84aa82c to 8cd2bd5 Compare November 5, 2024 17:22
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (691f104) to head (547f9d8).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #813   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files          62       62           
  Lines        3955     3955           
=======================================
  Hits         2709     2709           
  Misses       1246     1246           
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/routes/v0_1/graphs.py 96.82% <100.00%> (ø)

@jdbocarsly jdbocarsly force-pushed the jdb/item-graph-configuration branch from 78bbbef to f3a5601 Compare November 5, 2024 17:37
@ml-evs ml-evs force-pushed the jdb/item-graph-configuration branch from f3a5601 to 13e2705 Compare November 5, 2024 17:46
@jdbocarsly jdbocarsly force-pushed the jdb/item-graph-configuration branch 4 times, most recently from a848362 to 9a231b4 Compare November 13, 2024 00:08
@jdbocarsly jdbocarsly force-pushed the jdb/item-graph-configuration branch from 9a231b4 to 08a4790 Compare November 13, 2024 15:13
@jdbocarsly jdbocarsly changed the title [WIP] Add display configuration options to the Item Graph Add display configuration options to the Item Graph Nov 25, 2024
@jdbocarsly jdbocarsly force-pushed the jdb/item-graph-configuration branch from b81d370 to 898104f Compare November 25, 2024 17:30
@ml-evs ml-evs marked this pull request as ready for review November 27, 2024 14:46
@ml-evs ml-evs force-pushed the jdb/item-graph-configuration branch from 898104f to 547f9d8 Compare November 27, 2024 14:46
@ml-evs ml-evs changed the title Add display configuration options to the Item Graph Add better layouts and configuration options to the Item Graph Nov 27, 2024
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me! Obviously hard to test in any meaningful way, as discussed we should move to moving more of this logic to the backend and testing for valid networks that way. I've deployed this on datalab.bocarslygroup.com and it works significantly better (like 10-100x faster) than our existing solution, so let's get it in!

@ml-evs ml-evs merged commit c15d7fb into main Nov 27, 2024
17 checks passed
@ml-evs ml-evs deleted the jdb/item-graph-configuration branch November 27, 2024 20:35
@ml-evs ml-evs added enhancement New feature or request webapp For issues/PRs pertaining to the web interface labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants