-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better layouts and configuration options to the Item Graph #813
Conversation
4570bdb
to
50fc5a1
Compare
datalab Run #2814
Run Properties:
|
Project |
datalab
|
Branch Review |
jdb/item-graph-configuration
|
Run status |
Passed #2814
|
Run duration | 06m 30s |
Commit |
b5b1335988 ℹ️: Merge 547f9d85cb187aee3a5c2f20c9bbbd712211308c into 691f1046395d15e0acc44d82454f...
|
Committer | Josh Bocarsly |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
405
|
View all changes introduced in this branch ↗︎ |
84aa82c
to
8cd2bd5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 68.49% 68.49%
=======================================
Files 62 62
Lines 3955 3955
=======================================
Hits 2709 2709
Misses 1246 1246
|
78bbbef
to
f3a5601
Compare
f3a5601
to
13e2705
Compare
a848362
to
9a231b4
Compare
9a231b4
to
08a4790
Compare
b81d370
to
898104f
Compare
…s of items are selected
…through works properly
…n error on component reload
…enerating each time the 'label items by name' checkboxes are checked
898104f
to
547f9d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me! Obviously hard to test in any meaningful way, as discussed we should move to moving more of this logic to the backend and testing for valid networks that way. I've deployed this on datalab.bocarslygroup.com and it works significantly better (like 10-100x faster) than our existing solution, so let's get it in!
Todo:
ctr is not defined
when the graph is generated, then returned to.Add button to not show any collections(deferred)Some options for coloring/styling the nodes(deferred)pre-populate the ItemSelect with the highest rank starting materials, since these are the most likely to need to be removed(deferred)