Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv and deps lockfiles in CI & pre-commit #851

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Aug 20, 2024

This should be the final step following #582, which strips pipenv from the CI.

We could consider adding a new job that also ensures the pipenv lock is consistent, but this can easily be done manually for now (and is tested indirectly by the api_dev docker build which uses pipenv for this reason).

@ml-evs ml-evs requested a review from jdbocarsly as a code owner August 20, 2024 12:39
@ml-evs ml-evs force-pushed the ml-evs/use-uv-in-ci branch from 872391a to 7fbabd7 Compare August 20, 2024 12:39
Copy link

cypress bot commented Aug 20, 2024



Test summary

132 0 0 0


Run details

Project datalab
Status Passed
Commit d056dd9 ℹ️
Started Aug 20, 2024 3:51 PM
Ended Aug 20, 2024 3:55 PM
Duration 04:24 💡
OS Linux Ubuntu -
Browser Multiple

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@ml-evs ml-evs force-pushed the ml-evs/use-uv-in-ci branch from 7fbabd7 to 59e5515 Compare August 20, 2024 13:23
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (baff653) to head (9266c66).
Report is 149 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #851   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          62       62           
  Lines        3884     3884           
=======================================
  Hits         2646     2646           
  Misses       1238     1238           
---- 🚨 Try these New Features:

@ml-evs ml-evs force-pushed the ml-evs/use-uv-in-ci branch from 22aa7fe to 085d595 Compare August 20, 2024 15:47
@ml-evs ml-evs force-pushed the ml-evs/use-uv-in-ci branch from 085d595 to 9266c66 Compare August 20, 2024 15:48
@ml-evs ml-evs changed the title Use uv and deps lockfiles in CI Use uv and deps lockfiles in CI & pre-commit Aug 20, 2024
@ml-evs ml-evs merged commit 9688763 into main Aug 20, 2024
19 checks passed
@ml-evs ml-evs deleted the ml-evs/use-uv-in-ci branch August 20, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant