Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close database ports by default #876

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 5, 2024

Changes recently introduced to make borg set up easier assumed that an external firewall was blocking 27017. This is probably not a safe assumption to make, instead lets close it by default.

@ml-evs ml-evs added the build For issues/PRs pertaining to the build or deployment of the package label Sep 5, 2024
@ml-evs ml-evs requested a review from jdbocarsly as a code owner September 5, 2024 09:10
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (6eb5633) to head (7e39950).
Report is 166 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          62       62           
  Lines        3890     3890           
=======================================
  Hits         2650     2650           
  Misses       1240     1240           

@ml-evs ml-evs merged commit aecdc32 into main Sep 5, 2024
19 checks passed
@ml-evs ml-evs deleted the ml-evs/close-ports-by-default branch September 5, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build For issues/PRs pertaining to the build or deployment of the package priority/high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant