Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component tests for DataTable Prime components #884

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Sep 24, 2024

Closes #1012
Closes #794
Closes #889

Add component test for:

  • SampleTable
  • CollectionTable
  • EquipmentTable
  • StartingMaterialTable

Add e2e test for:

  • startingMaterial (Only for EDITABLE_INVENTORY false, test that the button 'Add a starting material' isn't displayed)

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (c15d7fb) to head (0e70903).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files          62       62           
  Lines        3955     3955           
=======================================
  Hits         2709     2709           
  Misses       1246     1246           

Copy link

cypress bot commented Sep 24, 2024

datalab    Run #2817

Run Properties:  status check passed Passed #2817  •  git commit 4bdf84bc90 ℹ️: Merge 0e7090325fcb532e0f1dd9cfddc33d7c3016705a into c15d7fb9f47b369954213d1e60e7...
Project datalab
Branch Review bc/components_test
Run status status check passed Passed #2817
Run duration 07m 03s
Commit git commit 4bdf84bc90 ℹ️: Merge 0e7090325fcb532e0f1dd9cfddc33d7c3016705a into c15d7fb9f47b369954213d1e60e7...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes force-pushed the bc/components_test branch 2 times, most recently from fef8c4c to 404af58 Compare October 4, 2024 16:13
@ml-evs ml-evs added this to the v0.5.x milestone Oct 8, 2024
@BenjaminCharmes BenjaminCharmes added testing For issues/PRs that change how the package is tested API For issues/PRs pertaining to the API webapp For issues/PRs pertaining to the web interface labels Oct 8, 2024
@ml-evs ml-evs force-pushed the bc/components_test branch from 16f8c73 to 3043fe2 Compare October 17, 2024 11:37
@ml-evs ml-evs force-pushed the bc/components_test branch from 3043fe2 to 22da19f Compare November 6, 2024 15:24
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this is basically ready to merge from my side, once the tests are passing again. We can then start adding more incrementally

@BenjaminCharmes
Copy link
Contributor Author

I remove the starting_materials e2e test for now because the EDITABLE_INVENTORY is false by default. So we need to decide if we only test the starting_material page when we can't edit the inventory, or if we should test it when it's true (or both?)

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review November 27, 2024 15:54
Update components test with last updates

Update VUE_APP_EDITABLE_INVENTORY in Cypress

Update starting_materials test to work with EDITABLE_INVENTORY false

Fix date receive from Vuex store in cypress

Fix date receive from Vuex store in cypress

Fix date receive from Vuex store in cypress

Fix startMaterial cypress test
@ml-evs ml-evs force-pushed the bc/components_test branch from 9a07e26 to 0e70903 Compare November 27, 2024 20:36
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's park the EDITABLE_INVENTORY stuff as I think it will be refactored away soon anyway. Always useful to have more tests in any form!

@ml-evs ml-evs enabled auto-merge (squash) November 27, 2024 20:40
@ml-evs ml-evs changed the title Added test for DataTable Prime components Add component tests for DataTable Prime components Nov 27, 2024
@ml-evs ml-evs removed the API For issues/PRs pertaining to the API label Nov 27, 2024
@ml-evs ml-evs disabled auto-merge November 27, 2024 20:49
@ml-evs ml-evs merged commit 212e2ab into main Nov 27, 2024
16 checks passed
@ml-evs ml-evs deleted the bc/components_test branch November 27, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing For issues/PRs that change how the package is tested webapp For issues/PRs pertaining to the web interface
Projects
None yet
2 participants