Add Collapsible Functionality for Block Warnings #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
=======================================
Coverage 68.34% 68.34%
=======================================
Files 62 62
Lines 3921 3921
=======================================
Hits 2680 2680
Misses 1241 1241 |
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/collapsible-block-warning
|
| Run status |
|
| Run duration | 06m 18s |
| Commit |
|
| Committer | Benjamin Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
396
|
| View all changes introduced in this branch ↗︎ | |
BenjaminCharmes
force-pushed
the
bc/collapsible-block-warning
branch
from
478849b to
13da3cc
Compare
ml-evs
force-pushed
the
bc/collapsible-block-warning
branch
2 times, most recently
from
1232e3d to
7e1c110
Compare
ml-evs
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Works well, thanks @BenjaminCharmes!
I pushed a couple of minor tweaks (removing some test variable names and adjusted the displayed text) -- I'll merge now but please take a quick look.
One possible future improvement would be to expand the warnings/errors underneath the "number of errors" title rather than replacing it.
Implement collapsible functionality for block warnings
ml-evs
force-pushed
the
bc/collapsible-block-warning
branch
from
90a799b to
087dee8
Compare
ml-evs
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #838
Add collapsible functionality for block warnings