Add dropdown with actions buttons for selected items inside DataTable #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
=======================================
Coverage 68.34% 68.34%
=======================================
Files 62 62
Lines 3921 3921
=======================================
Hits 2680 2680
Misses 1241 1241 |
datalab
|
||||||||||||||||||||||||
| Project |
datalab
|
| Run status |
|
| Run duration | 06m 47s |
| Commit |
|
| Committer | Benjamin Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
396
|
BenjaminCharmes
force-pushed
the
bc/dynamic-button-dropdown
branch
from
831bf85 to
d17d5e8
Compare
|
Hey @jdbocarsly,
|
BenjaminCharmes
force-pushed
the
bc/dynamic-button-dropdown
branch
from
f72c8bb to
e18d1a1
Compare
ml-evs
force-pushed
the
bc/dynamic-button-dropdown
branch
from
e18d1a1 to
05cfe28
Compare
ml-evs
reviewed
Oct 3, 2024
BenjaminCharmes
force-pushed
the
bc/dynamic-button-dropdown
branch
2 times, most recently
from
1cc6919 to
3eeb595
Compare
jdbocarsly
requested changes
Oct 4, 2024
ml-evs
force-pushed
the
bc/dynamic-button-dropdown
branch
from
3eeb595 to
7ecd1ab
Compare
BenjaminCharmes
force-pushed
the
bc/dynamic-button-dropdown
branch
from
281b311 to
7449cd3
Compare
Add dropdown actions buttons for selected items inside DataTable Fix e2e cypress test to work with dropdown Fix e2e cypress test to work with dropdown Add dropdown actions buttons for selected items inside DataTable
Fix e2e cypress test to work with dropdown
Add a few minor changes
ml-evs
force-pushed
the
bc/dynamic-button-dropdown
branch
from
7449cd3 to
b622d28
Compare
ml-evs
previously approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Looks great to me, thanks @BenjaminCharmes! It looks like you've incorporated all Josh's changes so I'm happy to merge once after adding one tiny change
| @@ -318,6 +319,7 @@ describe.only("Advanced sample creation features", () => { | |||
| // Visit collections page and look for 'test_collection' | |||
| cy.visit("/collections"); | |||
| // Visit edit page of collection and check that the sample is there | |||
| cy.get('[data-testid="search-input"]').type("test_collection"); | |||
There was a problem hiding this comment.
Ah I now see what you meant the other day, this is a nice solution!
ml-evs
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #897
This PR refactors the "Add to Collection" and "Delete Selected" actions into a PrimeVue SplitButton dropdown.
Also add a small fix to make cypress e2e tests work with dropdown.