Explcitly set OAUTHLIB_INSECURE_TRANSPORT env var when present in .env
#928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab
|
||||||||||||||||||||||||
| Project |
datalab
|
| Run status |
|
| Run duration | 06m 18s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
396
|
ml-evs
force-pushed
the
ml-evs/tweak-dev-server
branch
from
45cca10 to
d224282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the docker-based dev server implicitly called
load_dotenvto load any environment variables into global state, as part offlask run. Since the dev containers have now been removed, it is useful to be able to control a few select env vars in this way through the gunicorn-based container.This PR hardcodes the setting of
OAUTHLIB_INSECURE_TRANSPORTas an env var, when specified in the.envfile. This allows OAuth login to be used locally without https.